Inherit build runner progress node from compiler if stderr is not a TTY#24733
Open
myclevorname wants to merge 1 commit intoziglang:masterfrom
Open
Inherit build runner progress node from compiler if stderr is not a TTY#24733myclevorname wants to merge 1 commit intoziglang:masterfrom
myclevorname wants to merge 1 commit intoziglang:masterfrom
Conversation
andrewrk
requested changes
Aug 7, 2025
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
please add a comment explaining why the tty check
andrewrk
requested changes
Aug 7, 2025
andrewrk
requested changes
Aug 8, 2025
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Thank you for the comment. Now I understand what the logic is attempting to do. I think asking if it is a TTY is the wrong question. Really, it should be checking if the ZIG_PROGRESS environment variable is present, in which case a parent process is requesting participation in an already existing progress node.
The reason for bothering to check in this case is an optimization, to avoid sending progress data from the build runner to the CLI unnecessarily since the CLI is doing nothing but forwarding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24722