Move ArrayListSentineled to std lib orphanage#7531
Merged
Vexu merged 2 commits intoziglang:masterfrom Dec 24, 2020
Merged
Conversation
Vexu
added
standard library
kubkon
reviewed
Dec 23, 2020
kubkon
reviewed
Dec 23, 2020
kubkon
approved these changes
Dec 23, 2020
Member
kubkon
left a comment
kubkon
left a comment
There was a problem hiding this comment.
In general, I find the new transformer ArrayList.toOwnedSliceSentinel much cleaner than an entirely separate container type ArrayListSentineled. Additionally, now it should be easier to maintain the said container as well. So 👍 from me.
andrewrk
approved these changes
Dec 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping the list sentinel terminated makes use of the type more difficult and expensive compared to a regular ArrayList. Combined with the fact that most usages of it that I could find either completely ignored the sentinel or could easily be replaced by the
toOwndedSliceSentinelfunction I added and that a lot of its functionality has bitrotten makes it hard to justify keeping it in the standard library.Closes #6968
Closes #6967