Support EZSPv19#734
Conversation
zigpy-review-bot
left a comment
There was a problem hiding this comment.
Approve — clean EZSPv19 bump following the established per-version pattern; full test suite passes locally.
Verified against the actual SiSDK 2026.6.0 headers (installed via slt, same as the firmware-builder CI):
ezsp-protocol.h:EZSP_PROTOCOL_VERSION 0x13✅ezsp-enum.h:SL_ZIGBEE_EZSP_CLEAR_BINDING_TABLE_ON_LEAVE = 0x006D, and it's the only new command vs 2025.12.3 ✅command-prototypes.h:void sl_zigbee_ezsp_clear_binding_table_on_leave(bool clear)— matches the{"clear": t.Bool}→{}schema ✅- The
0x006Dreuse is safe in bellows:getTransientKeyTableEntrylast held it and was removed in v13, so the inherited v18 chain has the slot free. - Re the MFG_STRING mystery: the deprecation isn't in
ezsp-enum.hbut inplatform_core/.../token_manager/inc/sl_token_manager_manufacturing.h, which now splits onSL_TOKEN_MANAGER_FORMAT_LEGACY— the Series-3 branch definesTOKEN_MFG_BOARD_NAMEbut drops exactlyTOKEN_MFG_STRING,TOKEN_MFG_BOOTLOAD_AES_KEY, andTOKEN_MFG_EZSP_STORAGE(Series 3 stores tokens as KLV keys in the SE MTP region, and those three didn't make the cut). So the three annotations match the header exactly.
|
Some more detail on the Root cause: Series 3 changed the physical token storage model. On Series 2, manufacturing tokens live at fixed flash offsets ( The deprecation is enforced host-side, on all platforms — not just Series 3. In 2026.6.0's reference host stub ( if (expectedTokenDataLength == 255) {
(void)fetchInt8uPointer(tokenDataLength); // skip whatever the NCP sent
return 255; // sentinel: deprecated/invalid
}The app-framework helpers grew matching tombstones: Per-token rationale for the other two
Implications for bellows (nothing to change now)
|
TheJulianJES
left a comment
There was a problem hiding this comment.
Nice! The MFG_STRING stuff seems interesting 🤔
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #734 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 61 64 +3
Lines 4184 4203 +19
=======================================
+ Hits 4165 4184 +19
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No new useful commands in this release but
MFG_STRINGhas been deprecated for some reason. I can't really figure out why. We rely on this manufacturing token to store the board manufacturer's name.MFG_BOARD_NAMEhas not been deprecated.Overrides via
XNCP_MFG_MANUF_NAMEandXNCP_MFG_BOARD_NAMEwill continue working without issues, as they don't actually store data in manufacturing tokens.