Skip to content

Refactor SonoffPresenceSenorClusterHandler and add report configuration for SNZB-04P#345

Closed
mguaylam wants to merge 2 commits intozigpy:devfrom
mguaylam:SNZB-04P
Closed

Refactor SonoffPresenceSenorClusterHandler and add report configuration for SNZB-04P#345
mguaylam wants to merge 2 commits intozigpy:devfrom
mguaylam:SNZB-04P

Conversation

@mguaylam
Copy link
Contributor

@mguaylam mguaylam commented Jan 3, 2025

Refactor SonoffPresenceSenorClusterHandler to better represent devices using this cluster and add report configuration for the tamper attribute in the SNZB-04P.

Partly fixes : zigpy/zha-device-handlers#3308

@codecov
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (91cc37b) to head (f65ad65).
Report is 31 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #345      +/-   ##
==========================================
- Coverage   96.50%   96.49%   -0.02%     
==========================================
  Files          61       61              
  Lines        9439     9440       +1     
==========================================
  Hits         9109     9109              
- Misses        330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES
Copy link
Contributor

With the following PR, we should be able to fully do this via quirks v2:

@mguaylam
Copy link
Contributor Author

mguaylam commented Mar 6, 2025

Implemented in zigpy/zha-device-handlers#3665.

@mguaylam mguaylam closed this Mar 6, 2025
@mguaylam mguaylam deleted the SNZB-04P branch March 6, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Device Support Request] Sonoff SNZB-04p Zigbee Door/Window Sensor

2 participants