Implement quirks v2 reporting config, optimize discovery#363
Merged
Implement quirks v2 reporting config, optimize discovery#363
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #363 +/- ##
==========================================
- Coverage 96.58% 96.58% -0.01%
==========================================
Files 61 61
Lines 9499 9512 +13
==========================================
+ Hits 9175 9187 +12
- Misses 324 325 +1 ☔ View full report in Codecov by Sentry. |
316c390 to
2948276
Compare
TheJulianJES
commented
Jan 27, 2025
This was referenced Jan 27, 2025
TheJulianJES
commented
Jan 27, 2025
Contributor
Author
|
This PR is ready IMO. It's also well-tested to verify that the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This implements quirks v2
reporting_configin ZHA. The quirks v2 processing forZCL_INIT_ATTRSis also optimized to not copyZCL_INIT_ATTRSfor every entity metadata object.A test is also added that actually checks the existing
ZCL_INIT_ATTRScode and new code:ZCL_INIT_ATTRSclass variable, affecting other cluster handler instancesZCL_INIT_ATTRSare correctly set (and doesn't contain attributes also inREPORTING_CONFIG)REPORT_CONFIGis correctly setreporting_configis set, thus binding it during ZHA device configurationAdditional information
Supersedes: