fix(broker): migrate legacy lock files#83
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the scoped broker supervisor to proactively migrate legacy “regular file” locks to the current proper-lockfile directory-lock format, and adjusts/regresses tests to ensure the lock directory is created while held and fully released/removed afterward.
Changes:
- Add a legacy lock migration step that unlinks a stale regular file at
paths.lockPathbefore acquiring the proper-lockfile directory lock. - Update the scoped-concurrency test to assert against the current lock path (directory lock) rather than the previous default “
.lock.lock” behavior. - Add a regression test ensuring a legacy regular lock file at
paths.lockPathis replaced by a directory lock and removed after release.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/relay/broker/supervisor.ts | Adds legacy lock-file removal to support migration to proper-lockfile directory locks for scoped broker supervision. |
| tests/relay/broker-supervisor.test.ts | Updates lock assertions and adds a regression test for legacy lock-file migration and lock release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation