This repository was archived by the owner on Mar 13, 2026. It is now read-only.
[FEATURE] implement asset merger management. closes #2912#3138
Merged
Conversation
Guite
reviewed
Nov 5, 2016
| zikula_asset_manager.lifetime: "1 day" | ||
| zikula_asset_manager.compress: false | ||
| zikula_asset_manager.minify: false | ||
|
|
Member
There was a problem hiding this comment.
Why not reusing the existing module vars (which would be more consistent for the user)?
Member
Author
There was a problem hiding this comment.
because I don't think it should be that dynamic. This isn't a feature that needs to be enabled/disabled a bunch of times by the user. Additionally, using parameters separates the legacy methods from the new.
Member
Author
There was a problem hiding this comment.
additionally, it should be a tiny bit faster (e.g. no DB lookup)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[FEATURE] implement asset merger management. closes #2912