Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

search also for user entities during lost user name and lost password processes, fixed #3274#3277

Merged
craigh merged 1 commit into1.4from
issue-3274
Dec 7, 2016
Merged

search also for user entities during lost user name and lost password processes, fixed #3274#3277
craigh merged 1 commit into1.4from
issue-3274

Conversation

@Guite
Copy link
Member

@Guite Guite commented Dec 6, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #3274
Refs tickets -
License MIT
Changelog updated no

@Guite Guite added this to the 1.4.5 milestone Dec 6, 2016
@Guite Guite self-assigned this Dec 6, 2016
@craigh
Copy link
Member

craigh commented Dec 6, 2016

I wonder if some of this is really BC code... maybe it could be marked deprecated. This is all mainly because of the transition right?

I intentionally didn't migrate all the users from the users table to the zauth_authentication_mapping table to minimize upgrade execution time and in order to not have to deal with duplicates, etc. It can be a real headache. The solution was allow users to upgrade themselves as they login. Overtime all the users would be converted. Maybe we can add some kind of CLI command or something to complete the job and then remove code like this in 2.0.

@Guite
Copy link
Member Author

Guite commented Dec 7, 2016

Maybe we can add some kind of CLI command or something to complete the job and then remove code like this in 2.0.

Won't help users without CLI access.
But we could consider an action within the admin area which converts 10 users and reloads itself until the job is done.

@craigh craigh merged commit d174eb6 into 1.4 Dec 7, 2016
@craigh craigh deleted the issue-3274 branch December 7, 2016 10:24
@craigh craigh modified the milestones: 1.4.4, 1.4.5 Dec 7, 2016
@zikulabot zikulabot deployed to Extension Library December 7, 2016 10:36 Active
@craigh craigh mentioned this pull request Apr 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants