Make all process operators interruptible#430
Open
reibitto wants to merge 9 commits intoseries/2.xfrom
Open
Conversation
Collaborator
|
@reibitto would love to get this merged. Would you be willing to pick this back up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #425
Methods like
exitCodewere interruptible but in particular the stream operators weren't interruptible. That should be fixed now.Also Scala.js and Scala Native interruption weren't working at all. I wasn't familiar with either Scala.js and Scala Native or the implementations that were added, but I managed to get Scala.js interruption fully working. Scala Native interruption is only partially working but it's an improvement over the previous state of things. Particularly
.timeout(...)isn't interrupting the process. Nothing I do works so perhaps it's Scala Native limitation currently. I'll keep an eye on it and see if a future Scala Native upgrade fixes the internalwaitFormethod.As part of this, I added proper tests for interruption for each operator (not just
exitCode). It's confirmed to be working.