ci: reduce duplicate release workflow runs - #273
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fforootd
marked this pull request as ready for review
June 12, 2026 17:27
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the npm release workflow shape to avoid unnecessary runs on main and to ensure publishing only happens after the corresponding ci.yml push run has succeeded, with tooling/tests/docs updated to keep the new contract intentional.
Changes:
- Restricts
.github/workflows/release-npm.ymlmain-push triggers to release-relevant paths and grantsactions: read. - Adds a “wait for main CI” gate (via
gh run list ... --commit "$GITHUB_SHA") ahead ofchangesets/action@v1publishing. - Extends the alpha-train guard script, unit tests, and release documentation/ADRs to reflect and enforce the new workflow behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
scripts/check-alpha-release-plan.mjs |
Enforces new release workflow invariants (path filters, actions: read, and “wait for main CI” before Changesets). |
docs/runbooks/release-alpha-train.md |
Updates runbook steps to note the main CI wait as part of the release flow. |
docs/adrs/023-lockstep-alpha-release-train.md |
Updates ADR to reflect waiting for main CI prior to publishing. |
docs/adrs/002-multi-package-release-strategy.md |
Updates release strategy ADR to describe the main CI wait behavior. |
apps/cli/tests/unit/scripts/check-alpha-release-plan.test.ts |
Adds unit coverage for the new workflow guard requirements. |
.github/workflows/release-npm.yml |
Adds path filters, actions: read, and a polling wait step for the matching ci.yml push run. |
.changeset/release-main-ci-wait.md |
Adds an empty changeset for this CI/workflow-only change. |
…uce-duplicate-release-runs # Conflicts: # .github/workflows/ci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-npmmain-branch runs to release-relevant filesci.ymlpush run to pass before Changesets can publishValidation
corepack pnpm nx test @zitadel/cli -- tests/unit/scripts/check-alpha-release-plan.test.tscorepack pnpm run check -- --only release