Fix multi-GPU placement for GRACE, WISE, and ULTRAEDIT#703
Merged
HaomingX merged 1 commit intoJun 29, 2026
Merged
Conversation
Collaborator
Author
Validation detailsI used a temporary forced two-GPU harness for the multi-GPU smoke test. Setup:
Methods tested:
Placement coverage per method:
Result:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GRACEAdapteron the same device as the edited layerWISEactivation masks to the activation-loss tensor device before multiplicationULTRAEDIT/ MALMEN hook indices to the layer input or gradient device before indexingValidation
git diff --checkpy_compilefor the changed source filesGRACE,WISE, andULTRAEDITThis validation checks multi-GPU runtime/device placement. It does not claim changes to editing quality metrics.