ci(auto-release-pr): create Promote+Release PRs as draft - #173
Merged
Conversation
Mirror of zk-coins/app#151 — the GITHUB_TOKEN that opens these PRs hits GitHub's anti-recursion policy and silently skips ci.yaml, leaving every staging-bound and develop-bound auto-PR without a pre-merge CI gate. Creating as DRAFT lets the operator's explicit `gh pr ready` toggle fire the `ready_for_review` event that IS allowed to trigger downstream workflows, so the full Lint & Build plus (with `ci:full` already applied at creation) Node + Shared Tests + Coverage Gate run against the actual PR HEAD before merge. Both workflows in this repo carry the same one-line addition: - auto-release-pr-staging.yaml (staging → develop) - auto-release-pr.yaml (develop → main, keeps ci:full label) Operator UX: one extra click. `gh pr ready <num>` (or the UI button) promotes the PR + runs CI in a single step.
TaprootFreak
marked this pull request as ready for review
June 1, 2026 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror of
zk-coins/app#151. Both auto-release-pr workflows now create their PRs as DRAFT so the operator'sgh pr readytoggle fires theready_for_reviewevent that triggers ci.yaml. PRs opened via the workflow'sGITHUB_TOKENwould otherwise hit GitHub's anti-recursion policy and silently skip ci.yaml — leaving every staging-bound and develop-bound auto-PR without a pre-merge CI gate (visible today on#166and#169).Change
Two-line addition (
--draft) in:.github/workflows/auto-release-pr-staging.yaml(staging → develop Promote PR).github/workflows/auto-release-pr.yaml(develop → main Release PR — keeps--label ci:fullfor the heavy M3 Ultra suite)Operator UX
Identical to before plus one click:
gh pr ready <num>(or UI "Ready for review" button) → CI starts (incl. heavy suite via the existingci:fulllabel on the Release PR)Test plan
ci:fullheavy suite