chore(web): remove #418 diagnostic instrumentation (1.4.0) - #423
Conversation
#418 is fixed (1.3.9 CommonJS build) and verified in real vscode.dev, so the temporary open-sequence logging added in 1.3.8 is no longer needed. Removes the diagStep/diag helpers, per-await step logging, the read-path facade wrappers, and the loadDatabaseFiles diag parameter. The browser establishConnection and loadDatabaseFiles are restored byte-identical to the post-1.3.7 in-process form (verified: git diff vs f16680a is empty). The in-process engine itself is unchanged. Bumps 1.3.9 -> 1.4.0. Verified: build OK (extension-browser.js still exports activate via cjs; worker-free; no '#418 web-open' markers); tsc --noEmit clean; npm test 334/334. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 38 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the extension version to 1.4.0 and removes the temporary diagnostic logging and instrumentation (introduced for issue #418) from src/workerFactory.ts, restoring the browser connection path to its clean form. I have no feedback to provide as there are no review comments.
1 participant
Summary
Cleanup follow-up to the #418 fix. #418 is resolved (1.3.9, CommonJS browser build so
activate()is exported) and verified working in real vscode.dev — the SQLite Explorer grid renders, schema loads, no hang. The temporary open-sequence instrumentation added in 1.3.8 to locate the hang is no longer needed.Changes
diag/diagStephelpers and per-await step logging from the browserestablishConnection.diagStepwrappers on the read-path facade methods (ping,fetchSchema,fetchTableCount,fetchTableData,getTableInfo,getPragmas).diagparameter and per-file logging fromloadDatabaseFiles.[#418 web-open]lines to the output channel.The in-process sql.js engine (1.3.7) is unchanged.
src/workerFactory.tsis restored byte-identical to the post-1.3.7 in-process version (git diff f16680a -- src/workerFactory.tsis empty).Verification
extension-browser.jsstill exportsactivate(cjs fix intact), browser path worker-free, no#418 web-openmarkers.tsc --noEmit -p tsconfig.jsonclean ·npm test334/334.Bumps 1.3.9 → 1.4.0.