Skip to content

🧪 Fix import.meta.env globally by intercepting compilation in tests#484

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-main-test-import-meta-env-15635632877641194044
Closed

🧪 Fix import.meta.env globally by intercepting compilation in tests#484
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-main-test-import-meta-env-15635632877641194044

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎯 What:
Replaced the broken (globalThis as any).import = ... hack in tests/unit/main.test.ts with a functional compilation interceptor using Module.prototype._compile. It safely polyfills import.meta.env during CJS compilation, mirroring the workaround correctly implemented in workerFactory.test.ts.

📊 Coverage:
No production code was modified. The test suite for main.test.ts has been verified to pass successfully using tsx (10/10 passing).

✨ Result:
Tests are now robust against parsing failures for import.meta.env natively, ensuring testing stability without relying on a fundamentally invalid global JavaScript hack.


PR created automatically by Jules for task 15635632877641194044 started by @zknpr

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sq-lite-explorer Ready Ready Preview, Comment Jun 13, 2026 5:47pm

@zknpr

zknpr commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Closing: main.test.ts already passes — import.meta.env?.VSCODE_BROWSER_EXT falls through to the correct desktop default when the shim is absent, so this isn't fixing a real failure. It also overlaps with #478, which cleans up the same file more directly. The consistency intent (mirroring workerFactory.test.ts's compile interception) is reasonable, but closing as unnecessary churn. Thanks!

@zknpr zknpr closed this Jun 14, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

Closing: main.test.ts already passes — import.meta.env?.VSCODE_BROWSER_EXT falls through to the correct desktop default when the shim is absent, so this isn't fixing a real failure. It also overlaps with #478, which cleans up the same file more directly. The consistency intent (mirroring workerFactory.test.ts's compile interception) is reasonable, but closing as unnecessary churn. Thanks!

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant