🧪 Fix import.meta.env globally by intercepting compilation in tests#484
🧪 Fix import.meta.env globally by intercepting compilation in tests#484google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Closing: main.test.ts already passes — |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
🎯 What:
Replaced the broken
(globalThis as any).import = ...hack intests/unit/main.test.tswith a functional compilation interceptor usingModule.prototype._compile. It safely polyfillsimport.meta.envduring CJS compilation, mirroring the workaround correctly implemented inworkerFactory.test.ts.📊 Coverage:
No production code was modified. The test suite for
main.test.tshas been verified to pass successfully usingtsx(10/10 passing).✨ Result:
Tests are now robust against parsing failures for
import.meta.envnatively, ensuring testing stability without relying on a fundamentally invalid global JavaScript hack.PR created automatically by Jules for task 15635632877641194044 started by @zknpr