Update Syntax06

[tgreenx]

Purpose

This PR updates Syntax06 implementation in several aspects. I guess these were missed in the latest implementation update (#803) following the specification update (zonemaster/zonemaster#788).

Context

https://zonemaster.fr/en/result/24e61ae29cc4987e (see Syntax section)

Follow-up on #803

Changes

Deviations (from specification as of v2023.1):

• RNAME_RFC822_VALID was being outputted even if previous RNAME_MAIL_DOMAIN_INVALID were seen.
• RNAME_MAIL_DOMAIN_LOCALHOST and RNAME_MAIL_ILLEGAL_CNAME coverage was missing in unitary tests. Note that RNAME_MAIL_ILLEGAL_CNAME is still untested.

Corrections:

• RNAME_MAIL_DOMAIN_INVALID will now be outputted once per mail domain.
• Refactoring.

How to test this PR

Unit tests should pass. Also:

Now:

$ git log -2 --oneline
239e0f4 (HEAD -> update-syntax06, origin/update-syntax06) Update Syntax06 implementation and unitary tests
76b9dd9 (upstream/develop, develop) Merge pull request #1243 from zonemaster/master

$ zonemaster-cli --test=syntax/syntax06 com.gl --level=INFO --raw
   0.00 INFO     GLOBAL_VERSION   version=v4.7.0
   3.13 NOTICE   RNAME_MAIL_DOMAIN_INVALID   domain=cylnuw65dpky2iccpfjlennewaxz2voitry446wzkorpxyafryoq.mx-verification.google.com.

Before:

$ git log -1 --oneline
8ae6f4b (HEAD -> master, tag: v4.7.0, upstream/master, upstream/HEAD) Merge pull request #1242 from zonemaster/develop

$ zonemaster-cli --test=syntax/syntax06 com.gl --level=INFO --raw
   0.00 INFO     GLOBAL_VERSION   version=v4.7.0
   2.03 INFO     RNAME_RFC822_VALID   rname=gl-admin@tele.gl
   2.60 NOTICE   RNAME_MAIL_DOMAIN_INVALID   domain=cylnuw65dpky2iccpfjlennewaxz2voitry446wzkorpxyafryoq.mx-verification.google.com.
   2.89 NOTICE   RNAME_MAIL_DOMAIN_INVALID   domain=cylnuw65dpky2iccpfjlennewaxz2voitry446wzkorpxyafryoq.mx-verification.google.com.
   3.02 NOTICE   RNAME_MAIL_DOMAIN_INVALID   domain=cylnuw65dpky2iccpfjlennewaxz2voitry446wzkorpxyafryoq.mx-verification.google.com.
   3.16 NOTICE   RNAME_MAIL_DOMAIN_INVALID   domain=cylnuw65dpky2iccpfjlennewaxz2voitry446wzkorpxyafryoq.mx-verification.google.com.
   3.16 NOTICE   RNAME_MAIL_DOMAIN_INVALID   domain=cylnuw65dpky2iccpfjlennewaxz2voitry446wzkorpxyafryoq.mx-verification.google.com.

[ghost]

looks fine

[matsduf]

The SOA mail address for com.gl is gl-admin@tele.gl. The mail domain, as I see it, is tele.gl.

Then when mx for tele.gl is looked up, you get a list of mail server names:

$ dig tele.gl mx +short | cut -f2 -d' '
aspmx.l.google.com.
alt4.aspmx.l.google.com.
alt1.aspmx.l.google.com.
alt3.aspmx.l.google.com.
alt2.aspmx.l.google.com.
cylnuw65dpky2iccpfjlennewaxz2voitry446wzkorpxyafryoq.mx-verification.google.com.

Those should not be called "mail domains".

The last one gives NXDOMAIN.

[tgreenx]

Those should not be called "mail domains".

I have renamed variables and mentions of "mail domain" to "mail server" in the code, except in the message tags as those require an update to the specification first (but I don't think it's worth it). See commit 9aa8687.

[matsduf]

I have renamed variables and mentions of "mail domain" to "mail server" in the code, except in the message tags as those require an update to the specification first (but I don't think it's worth it). See commit 9aa8687.

The specification needs a larger update, so I agree with you. I will set up test zones for the test case.

[marc-vanderwal]

Looks fine; I just have a few style suggestions.

[tgreenx]

@matsduf @PNAX please re-review

[matsduf]

As I read the specification, RNAME_RFC822_VALID should be outputted in the nice case, but here nothing is outputted.

$ zonemaster-cli --test=syntax/syntax06 --level=INFO --raw sunet.se
   0.00 INFO     GLOBAL_VERSION  version=v4.7.3

[tgreenx]

As I read the specification, RNAME_RFC822_VALID should be outputted in the nice case, but here nothing is outputted.

$ zonemaster-cli --test=syntax/syntax06 --level=INFO --raw sunet.se
   0.00 INFO     GLOBAL_VERSION  version=v4.7.3

That's because this PR was based on old develop. I rebased, and now it should work as expected:

$ git log -1 --oneline
5d68ba59 (HEAD -> update-syntax06, origin/update-syntax06) Apply suggestions from code review

$ zonemaster-cli --test=syntax/syntax06 --level=INFO --raw sunet.se
   0.00 INFO     GLOBAL_VERSION  version=v4.7.3
  42.43 INFO     RNAME_RFC822_VALID  rname=hostmaster@sunet.se

[matsduf]

Release testing: Looks fine.