0.0.3#68
Merged
Merged
Conversation
Updated dependencies based on dependabot
Added raw webhook functionality
Added parameter validation to Node.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Submit changes to the RTMS SDK
Description
This PR integrates the latest RTMS C++ SDK (librtmsdk.0.20251026) and adds several enhancements including media parameter validation, session handling, event callbacks, and raw webhook support. Key updates include enhanced initialization with agent parameter support, complete session object with helper methods, onEventEx callback integration, comprehensive media parameter validations that enforce SDK constants, and advanced webhook handling with request/response access. The README has been updated with examples demonstrating the new features.
Related Issues
Integrates librtmsdk.0.20251026
Type of Change
Affected Components
Testing Performed
C++ Integration Testing:
Media Parameter Validation:
Raw Webhook Support:
Checklist
Additional Context
SDK Version: librtmsdk.0.20251016
Note on Metadata Fields: The metadata.user_name and metadata.user_id fields are blank when receiving data from the SDK. This has been confirmed through debug statements to be an issue in the core librtmsdk library, not in our wrapper code.
Media Parameter Validation: The validation ensures that users must use SDK constant enumerations (e.g., rtms.AudioContentType.RAW_AUDIO) rather than raw integers, preventing type safety issues and providing better error messages.
Webhook Integration: The raw webhook callback provides full access to HTTP request and response objects for advanced use cases like Zoom's webhook validation challenge, custom authentication, and custom responses. Documentation in README demonstrates this capability.
Session Handling: Full session object now includes helper methods for checking active/paused states, making it easier for users to track session status.
Event Callbacks: Added onEventEx support for receiving extended event data from the SDK.