Skip to content

Change checking for type of expression context to an assert. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 14, 2017
Merged

Change checking for type of expression context to an assert. #82

merged 4 commits into from
Sep 14, 2017

Conversation

@dhavlik
Copy link

@dhavlik dhavlik commented Sep 14, 2017

Name expression can only be "Load", so that the if makes no sense.

Change checking for type of expression context to an assert. Name exp…
f705290 
…ression can only be Load, so that the if makes no sense.
@dhavlik dhavlik requested a review from icemac September 14, 2017 11:26
Daniel Havlik and others added 2 commits September 14, 2017 14:49
icemac
icemac approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac merged commit 1a68792 into master Sep 14, 2017
@icemac icemac deleted the remove-context-checking-of-name-expressions branch September 14, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icemac icemac icemac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhavlik @icemac