Skip to content

Change checking for type of expression context to an assert. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2017
Merged

Change checking for type of expression context to an assert. #82

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f705290
Change checking for type of expression context to an assert. Name exp…
Sep 14, 2017
f659c5f
typo
Sep 14, 2017
c5df0c3
Update comment [skip ci]
Sep 14, 2017
430f216
Merge branch 'master' into remove-context-checking-of-name-expressions
Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/RestrictedPython/Eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,10 @@ def prepUnrestrictedCode(self):
used = set()
for node in ast.walk(exp_node):
if isinstance(node, ast.Name):
if isinstance(node.ctx, ast.Load):
used.add(node.id)
# As we are in 'eval' mode here, no other contexts
# should be possible, but who knows:
assert isinstance(node.ctx, ast.Load)
used.add(node.id)

self.used = tuple(used)

Expand Down