Skip to content

Conversation

@attakei
Copy link
Contributor

@attakei attakei commented Sep 21, 2017

When using {% bootstrap_css %} if settings.py has 'theme_url', the link tag for theme_url is generated wrong.
Because sanitize_url_dict() always generate dict(src=url) from URL string.
But in tag, URL resource path must be in href attribute.

Except:

<link ref="stylesheet" href="/static/css/theme.css" >

Actually:

<link ref="stylesheet" src="/static/css/theme.css">

This PR fixes it.

@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage increased (+0.1%) to 91.182% when pulling c2c67d2 on attakei:fix-link-attrs into c444cea on zostera:develop.

@jieter jieter merged commit 22e64f0 into zostera:develop Sep 24, 2017
@jieter
Copy link
Member

jieter commented Sep 24, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants