Handle changes of widgets inheritance #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Django 1.11, NumberInput, EmailInput, URLInput, PasswordInput switch from TextInput inheritance to Input inheritance. To be considered as widget with placeholder, I've updated is_widget_with_placeholder definition.
Member
|
@BiBzz thanks for the pull! Unfortunately, your change makes the test fail (some more things need to be imported). Can you try to fix that? |
Contributor
Author
|
Hi @jieter! Scuse me for the delay, it's my first PR, I haven't yet all good reflexes. |
Member
|
@BiBzz no worries, thanks for fixing and the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django 1.11, NumberInput, EmailInput, URLInput, PasswordInput switch from TextInput inheritance to Input inheritance.
To be considered as widget with placeholder, I've updated is_widget_with_placeholder definition.