Fix an issue with ensure_dir#127
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts z_filelib:ensure_dir/1’s internal helper first_missing/2 by changing its empty-input base case to return a tuple instead of a bare list, aiming to make the helper’s return shape consistent for callers handling symlink edge cases.
Changes:
- Updated
first_missing/2base case to return a 2-tuple when the input list is empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
first_missing/2function insrc/z_filelib.erlto alter its return value. Instead of returning just the reversed accumulator list when the input list is empty, it now returns a tuple containing the reversed accumulator and an empty list.src/z_filelib.erl: Modified the base case offirst_missing/2to return{lists:reverse(Acc), []}instead oflists:reverse(Acc).