Skip to content

fix: cache items only when coming from trusted proxy - #4706

Merged
achmelo merged 22 commits into
v2.x.xfrom
reboot/cache-key
Jun 15, 2026
Merged

fix: cache items only when coming from trusted proxy #4706
achmelo merged 22 commits into
v2.x.xfrom
reboot/cache-key

Conversation

@achmelo

@achmelo achmelo commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

Caching service allows to store items under the arbitrary value in header if the request is authenticated with client certificate. This change makes the validation more strict and allow to items only when the request is coming from a trusted proxy. It also drops support for custom header and keeps only standard Client-Cert header.

Linked to #4651

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

achmelo added 7 commits June 10, 2026 15:13
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: achmelo <37397715+achmelo@users.noreply.github.com>
@github-actions github-actions Bot added the Sensitive Sensitive change that requires peer review label Jun 11, 2026

@pablocarle pablocarle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title the of PR.
Most questions can be out of ignorance, take them with a grain of salt

Comment thread caching-service/src/main/resources/application.yml Outdated
Comment thread caching-service-package/src/main/resources/bin/start.sh Outdated
Comment thread caching-service/src/main/resources/application.yml
@achmelo achmelo changed the title Reboot/cache key fix: cache items only when coming from trusted proxy Jun 11, 2026
achmelo added 6 commits June 11, 2026 14:25
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
…rvice registration

Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
achmelo and others added 7 commits June 12, 2026 09:44
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@achmelo
achmelo merged commit bef7949 into v2.x.x Jun 15, 2026
34 checks passed
@achmelo
achmelo deleted the reboot/cache-key branch June 15, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sensitive Sensitive change that requires peer review size/XXL

Projects

Development

Successfully merging this pull request may close these issues.

2 participants