Skip to content

fix: Add validation hostname of registered service against allowed list#4833

Merged
pavel-jares-bcm merged 13 commits into
v3.x.xfrom
reboot/v3-allowed-list-host-name
Jul 23, 2026
Merged

fix: Add validation hostname of registered service against allowed list#4833
pavel-jares-bcm merged 13 commits into
v3.x.xfrom
reboot/v3-allowed-list-host-name

Conversation

@pavel-jares-bcm

@pavel-jares-bcm pavel-jares-bcm commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Description

Since #4656 APIML validates if URL in metadata during onboarding are matching with allowlist, but the hostname itself was not validated. This PR adds this condition.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@pavel-jares-bcm
add hostname to validation
62e45cc 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pavel-jares-bcm pavel-jares-bcm changed the title fox: Add validation hostname of registered service against allowed list fix: Add validation hostname of registered service against allowed list Jul 22, 2026
pavel-jares-bcm and others added 9 commits July 22, 2026 14:43
@pavel-jares-bcm
attempt to allow onboarding (hostname validation)
68ae093 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pavel-jares-bcm
Merge branch 'v3.x.x' into reboot/v3-allowed-list-host-name
23b91bb
@pavel-jares-bcm
wip
d9e29d0 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pavel-jares-bcm
fix
9e8b50d 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pavel-jares-bcm
Merge branch 'v3.x.x' into reboot/v3-allowed-list-host-name
92c5f8d
@pavel-jares-bcm
wip
1332fe8 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pavel-jares-bcm
fix
670f7d0 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pavel-jares-bcm
fix
685111c 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pavel-jares-bcm
Merge branch 'v3.x.x' into reboot/v3-allowed-list-host-name
27f7bd0
achmelo
achmelo reviewed Jul 23, 2026
View reviewed changes
Comment thread ...overy-service/src/test/java/org/zowe/apiml/discovery/metadata/MetadataFilterServiceTest.java
Comment thread integration-tests/src/test/java/org/zowe/apiml/util/service/VirtualService.java Outdated
Comment thread integration-tests/src/test/java/org/zowe/apiml/util/service/VirtualService.java Outdated
Comment thread .github/workflows/integration-tests.yml Outdated
Comment thread .github/workflows/integration-tests.yml Outdated
Comment thread integration-tests/src/test/java/org/zowe/apiml/functional/gateway/ServiceHaModeTest.java Outdated
@pavel-jares-bcm pavel-jares-bcm mentioned this pull request Jul 23, 2026
Open
10 tasks
pavel-jares-bcm and others added 3 commits July 23, 2026 13:58
@pavel-jares-bcm @achmelo
Update integration-tests/src/test/java/org/zowe/apiml/util/service/Vi…
1aae1fc 
…rtualService.java

Co-authored-by: achmelo <37397715+achmelo@users.noreply.github.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
@pavel-jares-bcm @achmelo
Update integration-tests/src/test/java/org/zowe/apiml/util/service/Vi…
7d15baa 
…rtualService.java

Co-authored-by: achmelo <37397715+achmelo@users.noreply.github.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
@pavel-jares-bcm
code review
1b0496f 
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jul 23, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 23, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pavel-jares-bcm
pavel-jares-bcm merged commit 5ff378f into v3.x.x Jul 23, 2026
48 checks passed
@pavel-jares-bcm
pavel-jares-bcm deleted the reboot/v3-allowed-list-host-name branch July 23, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achmelo achmelo achmelo approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavel-jares-bcm @achmelo