Rescript v12#37
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18c695e995
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | [_; "generate-schema"; sourceFolder; outputFolder] -> | ||
| GenerateSchema.generateSchema ~writeStateFile:true ~sourceFolder | ||
| ~debug:false ~outputFolder ~writeSdlFile:false ~printToStdOut:true | ||
| | [_; "completion"; path; line; col; currentFile] -> | ||
| Completion.completion ~debug:false ~path | ||
| ~pos:(int_of_string line, int_of_string col) | ||
| ~currentFile | ||
| | [_; "hover"; path; line; col] -> | ||
| Hover.hover ~path ~pos:(int_of_string line, int_of_string col) ~debug:false | ||
| | [_; "hover-graphql"; path; hoverHint] -> | ||
| Hover.hoverGraphQL ~path ~hoverHint |> print_endline | ||
| | [_; "definition-graphql"; path; definitionHint] -> | ||
| Hover.definitionGraphQL ~path ~definitionHint |> print_endline | ||
| | [_; "test"; path] -> Commands.test ~path | ||
| run_generate ~sourceFolder ~outputFolder ~writeSdlFile:false | ||
| | args when List.mem "-h" args || List.mem "--help" args -> prerr_endline help | ||
| | _ -> | ||
| prerr_endline help; |
There was a problem hiding this comment.
This command parser now accepts only generate-schema, but the editor/LSP path still invokes the private binary with completion, hover, hover-graphql, and definition-graphql (via Utils.callPrivateCli in the CLI layer). In this state those requests fall into the default branch, return exit code 1, and make execFileSync throw, so hover/completion/definition requests fail at runtime instead of returning JSON results.
Useful? React with 👍 / 👎.
1 participant
No description provided.