Entrypoint settings cleanup #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmv
force-pushed
the
entrypoint-settings
branch
from
8b894ca to
0e08f47
Compare
alexmv
force-pushed
the
entrypoint-settings
branch
from
0e08f47 to
f028941
Compare
This was removed from Zulip Server itself in zulip/zulip@72f5df2.
alexmv
force-pushed
the
entrypoint-settings
branch
2 times, most recently
from
1813c07 to
13b1877
Compare
This was left over in a refactoring in 33edaf3, and resulted in every backup directory having a close paren at the end of it.
Sadly, shellcheck cannot enforce this.
Defaulting to "False", this had the effect, if "True", of undoing the special-setting detection for the hard-coded list of setting names, and attempting to guess based only on the value. The name is at odds with the behaviour, and the behaviour seems unlikely to have been wanted.
The latter has no useful meaning anymore, and was removed in 149932e.
We do not call rabbitmqctl directly anymore.
It is not clear why this was added in the first place, but all it can do is produce 502's.
The only use of this was removed in 4a5b885.
alexmv
force-pushed
the
entrypoint-settings
branch
3 times, most recently
from
e9acbab to
85aa438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
How did you test this PR?
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: