-
-
Notifications
You must be signed in to change notification settings - Fork 9k
Switch to Django checks for config checking. #36600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+262
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What's the benefit of moving to the checks system? |
5922a2b to
25eb985
Compare
Collaborator
Author
|
Better error messages, rather than an assert stack trace. They also run implicitly, in more places. |
ad0583a to
1894610
Compare
alexmv
commented
Nov 17, 2025
alexmv
commented
Nov 17, 2025
c603a8b to
235c61c
Compare
Testsuites are given a pass, with `testserver` as the EXTERNAL_HOST, because it is embedded everywhere.
This became unnecessary in ee1801f.
Member
|
Merged, thanks @alexmv! |
Member
|
Backported for 11.5 in #36712. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
How changes were tested:
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: