Skip to content

Conversation

@alexmv
Copy link
Collaborator

@alexmv alexmv commented Nov 14, 2025

Fixes:

How changes were tested:

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@timabbott
Copy link
Member

What's the benefit of moving to the checks system?

@alexmv alexmv force-pushed the checks branch 2 times, most recently from 5922a2b to 25eb985 Compare November 14, 2025 18:03
@alexmv
Copy link
Collaborator Author

alexmv commented Nov 14, 2025

Better error messages, rather than an assert stack trace. They also run implicitly, in more places.

@alexmv alexmv force-pushed the checks branch 4 times, most recently from ad0583a to 1894610 Compare November 17, 2025 17:33
@alexmv alexmv force-pushed the checks branch 2 times, most recently from c603a8b to 235c61c Compare November 18, 2025 05:17
@timabbott timabbott merged commit 09f194b into zulip:main Nov 19, 2025
19 checks passed
@timabbott
Copy link
Member

Merged, thanks @alexmv!

@alexmv alexmv added the backport candidate Items we should consider backporting to the bug fix release series. label Nov 19, 2025
@alexmv alexmv mentioned this pull request Nov 20, 2025
12 tasks
@timabbott
Copy link
Member

Backported for 11.5 in #36712.

@timabbott timabbott removed the backport candidate Items we should consider backporting to the bug fix release series. label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants