Fix hrw4u and hrw_confcmp build on GCC/Linux#1
Merged
zwoop merged 1 commit intozwoop:Hrw4uCPPfrom Feb 17, 2026
Merged
Conversation
The hrw4u code was developed on macOS with Clang, which is lenient about C++20 designated initializer ordering and missing fields. GCC enforces these strictly: designators must appear in struct declaration order, and skipped fields trigger -Wmissing-field-initializers (fatal under -Werror). Fix Tables.cc by reordering all designators to match MapParams field order, Error.cc by adding the skipped .code field, and suppress the missing-field warning for the hrw4u target. Also add fPIC and ANTLR4 shared library fallback for systems without the static ANTLR4 library. The hrw_confcmp tool had three link failures on GNU ld: hrw_confcmp_lib was missing its dependency on hrw_confcmp_parser (which provides Parser and HRWSimpleTokenizer symbols), the CertBase::SAN::SANBase::Join stub returned std::string instead of cripts::string (different mangled name), and GNU ld's single-pass archive processing missed intra-library symbol references that macOS ld resolves automatically. (cherry picked from commit df0ed61c784f193a945a35a68e4f98a7ce59b503)
zwoop
pushed a commit
that referenced
this pull request
Feb 17, 2026
The hrw4u code was developed on macOS with Clang, which is lenient about C++20 designated initializer ordering and missing fields. GCC enforces these strictly: designators must appear in struct declaration order, and skipped fields trigger -Wmissing-field-initializers (fatal under -Werror). Fix Tables.cc by reordering all designators to match MapParams field order, Error.cc by adding the skipped .code field, and suppress the missing-field warning for the hrw4u target. Also add fPIC and ANTLR4 shared library fallback for systems without the static ANTLR4 library. The hrw_confcmp tool had three link failures on GNU ld: hrw_confcmp_lib was missing its dependency on hrw_confcmp_parser (which provides Parser and HRWSimpleTokenizer symbols), the CertBase::SAN::SANBase::Join stub returned std::string instead of cripts::string (different mangled name), and GNU ld's single-pass archive processing missed intra-library symbol references that macOS ld resolves automatically. (cherry picked from commit df0ed61c784f193a945a35a68e4f98a7ce59b503)
zwoop
pushed a commit
that referenced
this pull request
Feb 19, 2026
The hrw4u code was developed on macOS with Clang, which is lenient about C++20 designated initializer ordering and missing fields. GCC enforces these strictly: designators must appear in struct declaration order, and skipped fields trigger -Wmissing-field-initializers (fatal under -Werror). Fix Tables.cc by reordering all designators to match MapParams field order, Error.cc by adding the skipped .code field, and suppress the missing-field warning for the hrw4u target. Also add fPIC and ANTLR4 shared library fallback for systems without the static ANTLR4 library. The hrw_confcmp tool had three link failures on GNU ld: hrw_confcmp_lib was missing its dependency on hrw_confcmp_parser (which provides Parser and HRWSimpleTokenizer symbols), the CertBase::SAN::SANBase::Join stub returned std::string instead of cripts::string (different mangled name), and GNU ld's single-pass archive processing missed intra-library symbol references that macOS ld resolves automatically. (cherry picked from commit df0ed61c784f193a945a35a68e4f98a7ce59b503)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hrw4u code was developed on macOS with Clang, which is lenient about C++20 designated initializer ordering and missing fields. GCC enforces these strictly: designators must appear in struct declaration order, and skipped fields trigger -Wmissing-field-initializers (fatal under -Werror). Fix Tables.cc by reordering all designators to match MapParams field order, Error.cc by adding the skipped .code field, and suppress the missing-field warning for the hrw4u target. Also add fPIC and ANTLR4 shared library fallback for systems without the static ANTLR4 library.
The hrw_confcmp tool had three link failures on GNU ld: hrw_confcmp_lib was missing its dependency on hrw_confcmp_parser (which provides Parser and HRWSimpleTokenizer symbols), the CertBase::SAN::SANBase::Join stub returned std::string instead of cripts::string (different mangled name), and GNU ld's single-pass archive processing missed intra-library symbol references that macOS ld resolves automatically.
(cherry picked from commit df0ed61c784f193a945a35a68e4f98a7ce59b503)