fix(pds): address review suggestions on direct upload security and li… - #3
Merged
Conversation
Collaborator
安全审计结果静态审查 P2:密钥格式变更导致进行中的上传令牌失效
P2:新增日志存在日志注入风险
P2:上传令牌仍可重放,且未绑定用户/会话
P2:初始化接口缺少限流与失败清理直接上传信息接口会先调用 PDS 创建文件和上传会话,再生成令牌;当前流程缺少对应限流、大小上限及过期会话清理。拥有写权限的用户可以批量创建未完成会话,可能消耗远端对象、配额或 API 资源。建议增加限流、abort/GC 和文件大小限制。 正向修复:已增加文件名校验、强制过期时间校验、跨挂载点拦截,以及 5 分钟 hook 超时。 另外,当前 diff 末尾存在多余空行;本次未执行测试,仅基于静态审查。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.