Fix windows-arm64 GUI release builds - #8
Merged
Merged
Conversation
Install a pinned llvm-mingw aarch64 toolchain on the windows-11-arm gui-release leg so CGO doesn't fall back to the runner's x86 gcc, which can't assemble arm64 code. Also add a workflow_dispatch trigger that re-runs only gui-validate/gui-release against an existing tag, so a failed GUI leg can be retried without cutting a new release.
Member
Author
|
Reviewed before merge: llvm-mingw asset verified as the native aarch64 host toolchain with sha256 matched against the live release; trigger-path logic traced for both tag-push (unchanged behavior) and dispatch (gui jobs only, tag threaded through checkout, asset naming, and upload); input quoting checked for shell injection. No blocking findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-11-armgui-release leg only, prepend itsbinto PATH, and setCC/CXXto its clang wrappers — the runner's default gcc is x86-only and can't assemble arm64 (no such instruction: stp x29,x30), which is what broke run 29646239351 on tag v2.1.1.workflow_dispatchtrigger with a requiredtaginput that re-runs onlygui-validateandgui-releaseagainst an existing tag (checkout ref and the asset/upload tag both come from the input), guardingvalidate/releaseto skip on dispatch. Lets a failed GUI leg be re-published without cutting a new tag.validate/release/gui-validate/gui-releaseall still run exactly as before, usinggithub.ref/github.ref_namewhere the dispatch path uses the input.Test plan
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/release.yml'))"parses cleanlyactionlintpasses with no findings