Skip to content

Fix bugs in release workflow's package-libs matrix - #80

Merged
sqt merged 4 commits into
mainfrom
release-prep-package-libs-debug
Sep 3, 2026
Merged

Fix bugs in release workflow's package-libs matrix#80
sqt merged 4 commits into
mainfrom
release-prep-package-libs-debug

Conversation

@sqt

@sqt sqt commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Greptile Summary

The PR repairs macOS release packaging and corrects the shared-library presence check in the release workflow.

  • Repackages the macOS static archive for Apple linker compatibility.
  • Removes the problematic private runtime symbol from installed macOS dylibs.
  • Adds bundle validation controls and documents the required release dry-run process.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/release.yml Replaces the pipefail-sensitive shared-library probe with explicit file checks and adds verbose build output.
build.zig Adds the macOS deployment floor, Darwin archive repacking, and installed-dylib export filtering.
scripts/fix_macos_dylib_exports.sh Copies or post-processes the macOS dylib and verifies that the unwanted runtime export was removed.
scripts/verify_release_bundle.py Checks the macOS export trie and supports selecting which language examples are built against the bundle.
build.zig.zon Includes the new packaging script in distributed source packages.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Build[Build C and C++ bindings] --> Platform{macOS target?}
  Platform -- No --> Install[Install standard artifacts]
  Platform -- Yes --> Archive[Repack libzidl_cdr.a in Darwin format]
  Platform -- Yes --> Dylib[Filter ___dso_handle from installed dylib]
  Archive --> Verify[Verify install tree and bundle]
  Dylib --> Verify
  Install --> Verify
  Verify --> Consume[Build downstream bundle consumers]
Loading

Reviews (3): Last reviewed commit: "resolving CI issues" | Re-trigger Greptile

@sqt sqt changed the title Fix bug in release workflow's package-libs matrix Fix bugs in release workflow's package-libs matrix Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sqt
sqt merged commit ba93aa0 into main Sep 3, 2026
50 checks passed
@sqt
sqt deleted the release-prep-package-libs-debug branch September 3, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant