Fix the problem with inner double quotes#195
Conversation
| while (true) | ||
| { | ||
| int index2 = s.IndexOf(quote, index1); | ||
| if (index2 < 0) |
There was a problem hiding this comment.
Please use {} in this new code. Example:
if (index2 < 0)
{
break;
}| if (index2 < 0) | ||
| break; | ||
| if (index2 + 1 < s.Length && s[index2 + 1] == quote) | ||
| s = s.Remove(index2, 1); |
There was a problem hiding this comment.
Please use {} in this new code. Example:
if (index2 < 0)
{
break;
}
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 82.61% 82.86% +0.25%
==========================================
Files 37 37
Lines 3658 3671 +13
Branches 493 495 +2
==========================================
+ Hits 3022 3042 +20
Misses 498 498
+ Partials 138 131 -7
Continue to review full report at Codecov.
|
|
@StefH I made the required changes in the code. Something else needs to be done? |
OlegNadymov
left a comment
There was a problem hiding this comment.
@StefH, all required changes were done
|
Thanks a lot. A small question, how does the code behave if you use something like an incomplete escaped string as a search query? |
|
@StefH I've just tried it. And it works is like before. It throws |
|
@StefH may be you skipped my comment about new code. |
|
Ok. I will merge the code soon. |
|
@StefH ok! Thank you! And update nuget please. |
|
@StefH did you update nuget? |
|
Not yet sorry. Tomorrow morning. |
|
NuGets uploaded |
|
@StefH thank you!! |
Do I correct create expression for my case with inner double quotes?
After move from System.Dynamic.Linq to System.Dynamic.Linq.Core all my similar expressions were broken