Fix Parsing Config not passed down to expression parser in JOIN#201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
======================================
Coverage 82.5% 82.5%
======================================
Files 37 37
Lines 3681 3681
Branches 506 506
======================================
Hits 3037 3037
Misses 502 502
Partials 142 142
Continue to review full report at Codecov.
|
StefH
left a comment
There was a problem hiding this comment.
Looks good. Thanks for this fix!!!
Does this cover all scenarios?
|
I checked usages of ParseLambda() and all 27 references are properly propagating a ParsingConfig after the change. There is an overload that has 0 references, and which does not take a ParsingConfig. |
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
======================================
Coverage 82.5% 82.5%
======================================
Files 37 37
Lines 3681 3681
Branches 506 506
======================================
Hits 3037 3037
Misses 502 502
Partials 142 142
Continue to review full report at Codecov.
|
The ParsingConfiguration object is not properly propagated to CheckOuterAndInnerTypes() when calling the extension method Join.