Skip to content

Support strings as Enum Parameter Objects#37

Merged
StefH merged 4 commits intozzzprojects:masterfrom
jogibear9988:patch-1
Jul 22, 2016
Merged

Support strings as Enum Parameter Objects#37
StefH merged 4 commits intozzzprojects:masterfrom
jogibear9988:patch-1

Conversation

@jogibear9988
Copy link
Contributor

No description provided.

@jogibear9988
Copy link
Contributor Author

I can only compile net 4.5 on my system, and this works. hopefully you can help to fix the other?

@StefH
Copy link
Collaborator

StefH commented Jul 21, 2016

1]
There is a build error:
C:\projects\system-linq-dynamic-core\src\System.Linq.Dynamic.Core\ExpressionParser.cs(678,44): error CS7036: There is no argument given that corresponds to the required formal parameter 'ignoreCase' of 'Enum.Parse(Type, string, bool)'

2]
Can you please add/update unit-tests ?

@jogibear9988
Copy link
Contributor Author

Done

@StefH
Copy link
Collaborator

StefH commented Jul 22, 2016

Enum Parse with 'true' is case sensitive; is that what we want? I think other things are case insensitive?

@jogibear9988
Copy link
Contributor Author

sorry, i wanted to use false.

Von meinem iPhone gesendet

Am 22.07.2016 um 07:58 schrieb Stef Heyenrath notifications@github.com:

Enum Parse with 'true' is case sensitive; is that what we want? I think other things are case insensitive?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@StefH StefH merged commit 1b29a54 into zzzprojects:master Jul 22, 2016
@StefH
Copy link
Collaborator

StefH commented Jul 22, 2016

Merged and new NuGet created : https://www.nuget.org/packages/System.Linq.Dynamic.Core/1.0.5.2

@jogibear9988 jogibear9988 deleted the patch-1 branch July 24, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants