Skip to content

Fix MethodCallExpression when using NullPropagating (np)#443

Merged
JonathanMagnan merged 4 commits intomasterfrom
stef_np_432
Oct 30, 2020
Merged

Fix MethodCallExpression when using NullPropagating (np)#443
JonathanMagnan merged 4 commits intomasterfrom
stef_np_432

Conversation

@StefH
Copy link
Collaborator

@StefH StefH commented Oct 29, 2020

@StefH StefH requested a review from JonathanMagnan October 29, 2020 06:02
@StefH
Copy link
Collaborator Author

StefH commented Oct 29, 2020

@JonathanMagnan Some other unit tests fail, so do not merge this PR yet.

@StefH
Copy link
Collaborator Author

StefH commented Oct 29, 2020

Hello @JonathanMagnan, I did fix the code + unit tests. If you agree, I can merge this to master.

When that's doneI will start looking at #444.

@JonathanMagnan
Copy link
Member

Hello @StefH ,

I should be able to look at it tomorrow.

@JonathanMagnan
Copy link
Member

Look good ;)

Let me know if you wish I release during the weekend or wait for the #444 fix

@JonathanMagnan JonathanMagnan merged commit f523d2b into master Oct 30, 2020
@StefH StefH deleted the stef_np_432 branch November 14, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants