New features: Hexadecimal integers and array initializers#77
New features: Hexadecimal integers and array initializers#77StefH merged 5 commits intozzzprojects:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 81.5% 82.28% +0.78%
==========================================
Files 25 25
Lines 2898 2970 +72
Branches 425 448 +23
==========================================
+ Hits 2362 2444 +82
+ Misses 398 389 -9
+ Partials 138 137 -1
Continue to review full report at Codecov.
|
| Assert.Throws<ParseException>(() => values.Where("it < -2B")); | ||
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
Move this test method to the correct place in the file. (All methods are sorted alphabetically.)
| } | ||
|
|
||
| [Fact] | ||
| public void ExpressionTests_ArrayInitializer() |
There was a problem hiding this comment.
Move this test method to the correct place in the file. (All methods are sorted alphabetically.)
| if (c <= '\x007f') | ||
| { | ||
| c |= (char)0x20; | ||
| return c >= 'a' && c <= 'f'; |
There was a problem hiding this comment.
Will this also work for 'A' and 'F' (capital ?)
There was a problem hiding this comment.
Yes. Binary or with 0x20 makes all letters lowercase.
| NextChar(); | ||
| } while (char.IsDigit(_ch)); | ||
|
|
||
| bool hexInteger = false; |
There was a problem hiding this comment.
Code coverage from TextParser.cs dropped a bit, can you please check if you can add some more specific tests in this area?
| var list = new[] { 0, 1, 2, 3, 4 }; | ||
|
|
||
| //Act | ||
| var result1 = list.AsQueryable().SelectMany("new[] {}"); |
There was a problem hiding this comment.
Maybe add a test to test array in array ?
Like SelectMany("new[] { new[] { it + 1, it + 2 }, new[] { 10, 20 } }");
Array in array test.
|
Done |
StefH
changed the title
2 participants
Hexadecimal integers and array initializers