Remove slide deck reference from design.login.gov. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove slide deck reference from design.login.gov.
Remove "Coming soon!" pages from the design system.
* Toggle hidden content visible for visual regression tests **Why**: Check for regressions of content which may be collapsed (hidden) by default. * Apply lint fixes
Remove accessibility statement from design.login.gov in favor of it being on login.gov
**Why**: So that accessibility redirect introduced in #178 does redirect.
**Why**: The layouts are overly prescriptive, may fall (or have fallen) out of alignment with current recommendations, and are not the most useful of resources for referencing appearance or markup of page sections (footer, navigation, etc). This removal should be complemented by future work to either: - Reference base components from USWDS for additional guidance - Document and list differences between USWDS footer / navigation and the login.gov Design System
* Remove Spinner component button variant **Why**: This is out of sync with current guidance, where buttons which trigger a waiting experience have since been refined within the IdP to display with a pulsing dot animation. See: LG-3730, LG-3787, 18F/identity-idp#4517 * Merge 3.0.1 into unreleased changelog A 3.0.1 hasn't yet been published
**Why**: As someone using the login.gov Design System, I want to know when a component is implemented as an extension of the U.S. Web Design System, so that I can reference guidance from the USWDS documentation, and see specific implementation differences contained in the component stylesheet.
* Remove accessibility policies page **Why**: As of #178, this page is no longer referenced. * Exclude external redirect pages from sitemap **Why**: Since removal, not intended to be content of the site to be indexed. Reference: https://twitter.com/JohnMu/status/1031867308434759680 * Keep sitemap entry for redirected accessibility page **Why**: Maybe it is useful, so that Googlebot can find the new canonical resource? See: https://twitter.com/maxjpeters/status/1034288751030104064 * Add Images page with as adaptation of accessibility policies * Update decorative text hidden guidance See: #181 (comment) * Move Illustration brand guidance principles to Images page * Add introduction content to the images page. * Remove unused illustration from images page. * Remove outdated link to Illustration subsection Moved to Images page in c722baa * Remove unused id-confirm.svg image Removed in 0ff6281 * Remove unused "Decorative Illustration" screenshot Replaced with illustration graphics in c722baa * Update header content for accessibility. Co-authored-by: Julia Elman <julia.elman@gsa.gov>
**Why**: It's expected that the intention of these selectors was to match headings within `.usa-prose` following any other content in that prose block. Instead, due to the behavior of `&` in expanding the full selector ancestry, the generated output was along the lines of...
```
*+.usa-prose>h2,*+.usa-prose>h3 {
margin-top: 1.7em
}
```
This can be interpreted as "any content, followed by a prose block with a heading".
**Why**: So that we're publishing a consistent set of favicon icons, all of which use the Login.gov logo shield.
**Why**: So that projects importing subpaths from identity-style-guide don't fail if they respect native ES module `exports` definitions. See: https://nodejs.org/api/packages.html#packages_package_entry_points Co-Authored-By: Jessica Dembe <17969963+jmdembe@users.noreply.github.com> Co-authored-by: Jessica Dembe <17969963+jmdembe@users.noreply.github.com>
Co-Authored-By: Jessica Dembe <17969963+jmdembe@users.noreply.github.com> Co-authored-by: Jessica Dembe <17969963+jmdembe@users.noreply.github.com>
This pull request seeks to resolve an issue where focused buttons appear with two focus rings. The button styles included in the design system intend to unset the inherited focus styles from USWDS, but are not of high enough specificity to override the styles. Reference: https://github.com/uswds/uswds/blob/1f9bb1cc/src/stylesheets/global/_focus.scss#L1-L11
* Improve README guidance for release process **Why**: - Changelog should be edited to replace "Unreleased" with the release version. - Main branch is protected, so you cannot commit the version bump directly. Improve text to include steps for creating a branch, opening a pull request, and merging before creating a new release. - Dry-run testing is all well and good, but there wasn't any guidance around what exactly one should be looking for in considering whether "everything looks alright". * Add prerequisites text describing permissions process * Advise main branch pull to ensure latest changes are included
* LG-4226: Remove deprecated button variants This is the first of a couple pull requests toward LG-4226, and includes only removal of button variants no longer supported in the design system. These include: - Success (`usa-button--success`) - Dropdown (`usa-button--dropdown`) - Small (`usa-button--small`) - Tiny (`usa-button--tiny`) See LG-4226 for more detail. * Remove references to Other Buttons
* LG-4226: Improve support for unstyled button The unstyled button variant had previously existed in that it was inherited from USWDS, though it was not documented, and did not always display correctly, particularly in hover, active, and focus states. These changes improve this support, and adds documentation for the unstyled option. * Fix button heading hierarchy Don't skip heading levels https://dequeuniversity.com/rules/axe/3.5/heading-order * Improve unstyled button preview partial - Use utility classes - Improve mobile display
* Add wide button variants Adds two new button variants: 1. Minimum width occupies full width on mobile, and a minimum width on wider viewports 2. Full width always occupies full width * Remove redundant mobile width style **Why**: Already full-width at small viewports * Switch wide buttons to min-width at mobile-lg **Why**: Match USWDS cut-over. See: - https://github.com/uswds/uswds/blob/1f9bb1c/src/stylesheets/elements/_buttons.scss#L24-L26 - #192 (comment) * Update documented text to match Figma
* Rename "Secondary" as "Outline" in buttons documentation * Document big buttons * Rescale buttons per Figma * Increase border radius to 0.5rem for big buttons Per design See: #193 (review) * Match button hover, active text color to border Inherit most styles from USWDS
**Why**: As a consumer of the login.gov Design System, I expect to be able to override the default full-width button appearance on mobile to allow for flexible-width buttons, so that I can create interfaces where the button is shown adjacent to other text or controls. Currently, all buttons are shown as full-width at mobile viewports. There are a few instances in the IDP of buttons appearing as "flexible width", with text or interactive content shown next to the button. These are not the majority, so an override option is included to let the developer choose to force the width to shrink as flexible, while retaining the current default behavior. In discussing this with @anniehirshman-gsa , it was considered whether a similar exception override class should be included for minimum-width buttons (e.g. `usa-button--minimum-width`). There are currently no use-cases for this, so it was decided to defer this for future consideration if ever it becomes relevant.
* Remove password strength meter component * Remove zxcvbn dependency Unused after removal of password strength component
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* 5.0.0 * Bump CHANGELOG version to published version
* Remove re-application of unstyled button styles **Why**: It should not be necessary, because USWDS handles hover and active unstyled states, but does not currently do so for the modifier classes. Previously, we worked around this by including the unstyled button mixin, which would have a higher specificity than the default button's hover styles. Unfortunately, this also comes with some unexpected consequences, such as the re-application of the USWDS focus ring, which we expect to override in our own default button styles. * Add changelog entry * 5.0.1 * Re-include (unprefixed) unstyled button styles to reset big, base overrides **Why**: We customize big button padding and border radius, which should not extend to apply to the unstyled button. This is controlled in USWDS by applying unstyled styles last. We must similarly reapply unstyled button styles after our customizations. Unlike prior to afecbdd, don't give extra specificity and instead rely on style order, similar to as in base USWDS styles.
…led radios and checkboxes, LG-6230
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
…ty-style-guide into checkbox-disabled-and-checked
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: improvements, add style and markdown for checked and disab…
Prepare Release 6.4.2
**Why**: To avoid future maintenance burden, and to take advantage of latest features and bug/security fixes.
* LGDS: Update line height value for accordion component **Why**: To improve readability when the accordion heading spans multiple lines of text. * Sync banner accordion button to text Decrease from 1.5 to 1.2 to match See: #316 (comment)
* Bump devDependencies to latest version **Why**: - Keep on top of dependency upgrades to avoid future maintenance headaches - Take advantage of latest bug fixes and feature enhancements - Resolve security advisories - Prepare for upcoming package release * Align browserslistrc to IdP Looks like it may not have previously been supporting IE11 as expected, evidenced by modern syntax remaining in output
Remove "content" section
**Why**: [Federalist is becoming Cloud.gov Pages](https://cloud.gov/pages/federalist-migration/), and as such we'll need to update configurations accordingly.
* Update Text Input styling to adhere to design specification * Add global "override" for block input margin
* Add "Big" variant of Text Input, Textarea * Update navigation links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.