Skip to content

Add tests on parser about variables declaration - #8783

Merged
4ian merged 2 commits into
masterfrom
test-undeclared-variables
Jun 29, 2026
Merged

Add tests on parser about variables declaration#8783
4ian merged 2 commits into
masterfrom
test-undeclared-variables

Conversation

@D8H

@D8H D8H commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Cover combinations of

  • expression, variable parameter, legacy variable parameter
  • variables from a depth of 1 to 3
  • declared or undeclared variable at each level

Some cases were already covered and don't appear in the diff.

@D8H
D8H requested a review from 4ian as a code owner June 29, 2026 13:12
Comment on lines -3661 to +3787
SECTION("Declared scene variable") {
auto node = parser.ParseExpression("MySceneVariable");
SECTION("Declared scene variable with missing gran-children in expression") {

@D8H D8H Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved these 2 tests at the top

@4ian
4ian merged commit f9af900 into master Jun 29, 2026
6 checks passed
@4ian
4ian deleted the test-undeclared-variables branch June 29, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants