Fix crash in sprite list - #8920
Merged
Merged
Conversation
…moved or deleted The children render-prop, beginDrag and thumbnail callbacks captured a gd.Sprite wrapper created at render time. react-dnd re-invokes these closures on drag monitor state changes, after direction.moveSprite() or a deletion invalidated the underlying C++ object, causing 'memory access out of bounds'/UseAfterFreeError crashes in the object editor (the most frequent crash reported in 5.6.276). Closures now only capture the sprite pointer and image name extracted at render time. Also guard deleteSprites against reading the first sprite of an empty first direction (Direction::GetSprite is unchecked in C++). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tAYyjBj4D4s2h32iN1eL1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.