[Address Book V2] - Export address book#2284
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Great work, @matextrem!
Did you manage to simulate an error state?
|
Noticed a small bug:
it will show a success notification. |
|
Adding to what Lukas said, please call it |
I'm happy either way. I just think it needs to be consistent. I totally agree with you based on your links that the one with a space is more common. In English, words aren't connected together endlessly like in German. Then let's use |
I tried it by hardcoding the error state to see how the UI behaves |
nicosampler
left a comment
There was a problem hiding this comment.
Let's implement the styles using styled-components instead of material 🙏🏾.
We should only use the styles from material when we are editing a component and we don't want to refactor the code, but as this is a completely new code, we should definitely go with styled.
|
Looks and works great! Just one last detail I would add: disable/add loader to the download button after clicking on it. |
|
I'll go ahead and merge this PR. Will make a separate ticket for the button state. |

What: This new feature allow users to export their Address book as CSV.
Why: As part of the new redesign of the Address Book. This PR closes #2235
How to test it: