Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

[Address book v2] Address book update events#2293

Merged
katspaugh merged 4 commits into
address-book-v2from
2240-address-book-update-events
May 17, 2021
Merged

[Address book v2] Address book update events#2293
katspaugh merged 4 commits into
address-book-v2from
2240-address-book-update-events

Conversation

@dasanra

@dasanra dasanra commented May 14, 2021

Copy link
Copy Markdown
Collaborator

What:
Closes #2240 #2252
This PR is intended to do a check on the address book add, update and remove events. It will ensure that in each place where a name can be added or edited its value is stored in the address book

Why:
We want to ensure that we use a central source of truth, and so we are relaying on the address book to create the relationship between an address and a name, instead of keeping update in two places for the case of safe owners and an added safe

How:
I did a review of all places where an address name can be edited and ensured that this changes were persisted in the address book. Then I also ensured that on every place that we show an address name this value is picked from the address book

How to test it:

  • Create safe – safe name is stored in the address book
  • Load safe - safe name is stored in the address book
  • Add an owner - check name in address book
  • Replace an owner - check name in address book
  • Edit safe name in settings
  • Edit owner name in settings
  • Directly create an address book entry
  • Directly edit an address book entry
  • Check that address book name is shown on transaction details
  • Name stored in address book it's used over known address name from client-gateway
  • Deleting a safe using settings button don't delete the address from the address book
  • Name shown in assets "send" is updated
  • Name shown in assets "receive" is updated
  • Name shown in transaction details for owners is correct
  • Name shown in address book "send" is correct
  • Names shown in settings > spending limits are correct

Checklist:

  • Ready to be merged

@dasanra dasanra self-assigned this May 14, 2021
@github-actions

Copy link
Copy Markdown

CLA Assistant Lite All Contributors have signed the CLA.

@dasanra dasanra changed the title Address book update events [Address book v2] Address book update events May 14, 2021
@github-actions

github-actions Bot commented May 14, 2021

Copy link
Copy Markdown

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

@katspaugh katspaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@fernandomg fernandomg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@katspaugh katspaugh merged commit 7b00ee1 into address-book-v2 May 17, 2021
@katspaugh katspaugh deleted the 2240-address-book-update-events branch May 17, 2021 15:06
@github-actions github-actions Bot locked and limited conversation to collaborators May 17, 2021
@katspaugh

Copy link
Copy Markdown
Contributor

I'll move the "how to test" section from this PR to the epic where it was merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants