Prevent useless onSelectedRangesChanged events in selectionmodels' setSelectedRanges - #10
Merged
Conversation
…selectionmodels' setSelectedRanges
6pac
added a commit
that referenced
this pull request
Jun 2, 2015
Prevent useless onSelectedRangesChanged events in selectionmodels' setSelectedRanges
6pac-ai
added a commit
that referenced
this pull request
Jul 18, 2026
Six-dimension adversarial equivalence audit of the M18 series (creation paths, widths, heights/visibility/markers, compat getters + shared arrays, cellrangeselector, cross-cutting invariants) against pre-M18 (484988d^). Everything verified equivalent except: - cellrangeselector: add a positional fallback to the frozen-band marker query. Restores byte-equivalence in the degenerate frozenRow: 0 variants (incl. the frozenBottom body-height quirk) and covers stale-marker suppressColumnSet transition windows. - materializeRightFrozenBand: drop the ensureBottomFrozenRightVariant call from the already-exists early return (restores exact pre-M18 shape). The state it guarded is unreachable, and if it ever fired the corner would be created without pane events (the grid caller binds nothing on that path). Accepted deltas documented as KNOWN-QUIRKS #10-13: canonical shared-array band order, impossible-state TypeErrors -> silent skips, read-only compat getters, markers-stale-when-visibility-stale. Gates: tsc/eslint clean, shape+band+drag gate 74/74, full suite 636 / 0 failing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6pac-ai
added a commit
that referenced
this pull request
Jul 18, 2026
Six-dimension adversarial equivalence audit of the M18 series (creation paths, widths, heights/visibility/markers, compat getters + shared arrays, cellrangeselector, cross-cutting invariants) against pre-M18 (484988d^). Everything verified equivalent except: - cellrangeselector: add a positional fallback to the frozen-band marker query. Restores byte-equivalence in the degenerate frozenRow: 0 variants (incl. the frozenBottom body-height quirk) and covers stale-marker suppressColumnSet transition windows. - materializeRightFrozenBand: drop the ensureBottomFrozenRightVariant call from the already-exists early return (restores exact pre-M18 shape). The state it guarded is unreachable, and if it ever fired the corner would be created without pane events (the grid caller binds nothing on that path). Accepted deltas documented as KNOWN-QUIRKS #10-13: canonical shared-array band order, impossible-state TypeErrors -> silent skips, read-only compat getters, markers-stale-when-visibility-stale. Gates: tsc/eslint clean, shape+band+drag gate 74/74, full suite 636 / 0 failing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9