doctor: add --skip-native-check flag#488
Merged
Merged
Conversation
Owner
|
Yes, makes sense. This part of the project has to be revisited though: this is not enough to check for simple socket opening, we also need to ping those servers with RPC pings. Current verification is a very shallow unfortunately. Thank you! |
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--skip-native-checkflag tomtg doctorthat skips the Validate native network connectivity section.When proxy chaining is configured (
network.proxies), the native dialer is intentionally not the path used to reach Telegram DCs, so this section currently times out for every DC. #485 makes those dials concurrent (worst case ~10s instead of ~60s), but for users who know native egress is broken by design, even a single 10s window is wasted time on everymtg doctorinvocation.The check is still useful by default (it confirms the host can reach Telegram directly when no proxy is configured), so the behavior is opt-in.
Sample output with the flag set:
Scope is intentionally narrow — only
checkNetwork(base)is gated.checkFrontingDomainalso uses the native dialer, but it is conceptually distinct (it tests whether the proxy host itself can reach the fronting domain, which is still meaningful under chain-mode), so it is left untouched.This re-sends the same diff as the previously closed #484 — closed it prematurely thinking #485 alone would be enough; the issue reporter clarified in #482 (comment) that both the speedup and the skip option are wanted. Independent of #485 and can land in either order.
Closes #482.
Test plan
mergeable_state: cleanmtg doctor --skip-native-check config.tomlagainst a chained-proxy config, confirm the native section is skipped and the rest of the report runs normally