Skip to content

compose: fix non-functional 'host' option#514

Merged
9seconds merged 2 commits into
9seconds:masterfrom
bam80:patch-2
May 20, 2026
Merged

compose: fix non-functional 'host' option#514
9seconds merged 2 commits into
9seconds:masterfrom
bam80:patch-2

Conversation

@bam80
Copy link
Copy Markdown
Contributor

@bam80 bam80 commented May 16, 2026

@bam80
Copy link
Copy Markdown
Contributor Author

bam80 commented May 16, 2026

I don't know what is this CI/Test error below about:
https://github.com/9seconds/mtg/actions/runs/25975130478/job/76353850541?pr=514

@dolonet
Copy link
Copy Markdown
Collaborator

dolonet commented May 18, 2026

Thanks — bug is real. :2 currently resolves to v2.2.8 (2026-04-07), which predates #480 in master, so the host = "web" example from the README fails on docker compose up.

Your fix works: per .github/workflows/ci.yaml, :latest is published with enable={{is_default_branch}}, so the latest tag tracks master HEAD.

One small suggestion (non-blocking): consider explicit :master plus a one-line comment, e.g.

mtg:
  # :master until #480 lands in a tagged release; switch back to :2/:3 after release
  image: nineseconds/mtg:master

vs. bare nineseconds/mtg. Reasoning: a casual reader assumes :latest is "stable", but here it follows master, which is non-obvious. Explicit :master makes the temporary nature visible and makes the post-release cleanup obvious. Up to you — either version fixes the immediate breakage.

Heads-up on merge timing: I have write access to this repo, but for others' PRs I self-merge only when (a) it's contrib/docs-only, (b) clearly within scope @9seconds would accept, and (c) the PR has sat ≥7 days without his activity. So this will wait on him; if he hasn't reacted by then I'll merge regardless of which form you pick.

@bam80
Copy link
Copy Markdown
Contributor Author

bam80 commented May 18, 2026

Done. I hope we can auto-squash here, do not want to bother.

@dolonet
Copy link
Copy Markdown
Collaborator

dolonet commented May 19, 2026

Thanks for the fixup — change looks good, CI is green. Holding to the 7-day window per the policy above: if @9seconds hasn't reacted by 2026-05-23 (7 days after PR open), I'll squash-merge so the fixup folds into your commit. Nothing more needed from you.


P.S. @9seconds — when you have a moment, could you sanity-check this self-merge policy? A flat 7-day wait works but feels heavy for one-line fixes like this. A tiered version I'd propose:

  • Minor (one-line contrib/docs fixes, typos, broken examples, urgent fixes): merge once two people are OK with it (PR author + one collaborator) and CI is green — no wait.
  • Middle (larger contrib changes, README restructures, CI tweaks): keep the 7-day wait, then merge.
  • Major (anything in mtglib/, internal/, mtgproxy/, network/TLS/handshake, config surface, public API, behavior-changing dependency bumps): never self-merge; only triage and prepare it for your review.

Happy to stay with the strict 7-day rule if you'd rather — just want to calibrate to what's useful to you.

@9seconds
Copy link
Copy Markdown
Owner

Sure, agree. Hopefully now I gonna have a bit more bandwith to resume an active work on this project, so 7 days windows will be very rare. Sorry everyone, had a tough period

@9seconds 9seconds merged commit 270ea99 into 9seconds:master May 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

contrib/sni-router: 'host' option is non-functional

3 participants