compose: fix non-functional 'host' option#514
Conversation
|
I don't know what is this CI/Test error below about: |
|
Thanks — bug is real. Your fix works: per One small suggestion (non-blocking): consider explicit mtg:
# :master until #480 lands in a tagged release; switch back to :2/:3 after release
image: nineseconds/mtg:mastervs. bare Heads-up on merge timing: I have write access to this repo, but for others' PRs I self-merge only when (a) it's contrib/docs-only, (b) clearly within scope @9seconds would accept, and (c) the PR has sat ≥7 days without his activity. So this will wait on him; if he hasn't reacted by then I'll merge regardless of which form you pick. |
|
Done. I hope we can auto-squash here, do not want to bother. |
|
Thanks for the fixup — change looks good, CI is green. Holding to the 7-day window per the policy above: if @9seconds hasn't reacted by 2026-05-23 (7 days after PR open), I'll squash-merge so the fixup folds into your commit. Nothing more needed from you. P.S. @9seconds — when you have a moment, could you sanity-check this self-merge policy? A flat 7-day wait works but feels heavy for one-line fixes like this. A tiered version I'd propose:
Happy to stay with the strict 7-day rule if you'd rather — just want to calibrate to what's useful to you. |
|
Sure, agree. Hopefully now I gonna have a bit more bandwith to resume an active work on this project, so 7 days windows will be very rare. Sorry everyone, had a tough period |
Fix #511
@dolonet