Allow disabling no-htlc commitment fee-bump#2246
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2246 +/- ##
==========================================
- Coverage 84.73% 84.68% -0.05%
==========================================
Files 194 194
Lines 14628 14640 +12
Branches 615 631 +16
==========================================
+ Hits 12395 12398 +3
- Misses 2233 2242 +9
|
pm47
reviewed
May 3, 2022
t-bast
force-pushed
the
anchor-disable-commit-bump
branch
from
b74568b to
e2ddd11
Compare
t-bast
force-pushed
the
anchor-disable-commit-bump
branch
from
e2ddd11 to
ed69351
Compare
pm47
reviewed
Jun 29, 2022
When a channel force-close without any pending htlcs, funds are not at risk. We want to eventually get our main output back, but if we are not in a rush we can save on fees by never spending the anchors. This is disabled by default as there is a potential risk: if the commit tx doesn't confirm and the feerate rises, the commit tx may eventually be below the network's min-relay-fee and won't confirm (at least until package relay is available).
t-bast
force-pushed
the
anchor-disable-commit-bump
branch
from
f7f67fa to
480b9da
Compare
pm47
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a channel force-close without any pending htlcs, funds are not at risk. We want to eventually get our main output back, but if we are not in a rush we can save on fees by never spending the anchors.
This is disabled by default as there is a potential risk: if the commit tx doesn't confirm and the feerate rises, the commit tx may eventually be below the network's min-relay-fee and won't confirm (at least until package relay is available).