Sbra 357 propose dockerfile

[rmslm]

Create a docker file corresponding to the ai4sim env

[github-actions]

Coverage report for weather_forecast/gwd/ use-case

File	Coverage		Missing
All files	94%	✅
data.py	98%	✅	157
models.py	89%	✅	37-40 90 99
trainer.py	88%	✅	75-76 80

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 5375c11

[github-actions]

Coverage report for combustion/unets/ use-case

File	Coverage		Missing
All files	91%	✅
data.py	91%	✅	59 70 72 113 123 129
models.py	87%	✅	41-42 45 48
trainer.py	75%	❌	59-62 66-67 71
unet.py	96%	✅	83 89

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 5375c11

[github-actions]

Coverage report for combustion/gnns/ use-case

File	Coverage		Missing
All files	82%	✅
config.py	68%	❌	74-77 81 85-90 94-101
data.py	81%	✅	109-136 162 216
inferer.py	89%	✅	224-240
models.py	73%	❌	85 116-131 156-160 210-214
plotters.py	93%	✅	55-56 142-143 146-147 160 165
trainer.py	68%	❌	67-72 81-83 87-89

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 5375c11

[rdruilhe]

All the Dockerfiles seems to be lore or less the same. Why don't you create a single dockerfile with the use case as arguments. It will avoid maintaining multiple files that are almost identical.

[rdruilhe]

All the Dockerfiles seems to be lore or less the same. Why don't you create a single dockerfile with the use case as arguments. It will avoid maintaining multiple files that are almost identical.

[rdruilhe]

Each folder is independent from the others so that there is replication of code.

[leonicoletti]

Looks good to me

[A669015]

Clone the full repo in the image seem a bit overkill. Only the source of the use case could be embeded.
That could be done with a first temporary image used to retrive the source, and the final one will just copy the part it needs.

[A669015]

The docker image built in our internal repo are good example of the method.

[A669015]

The idea was to use a donwloader image (as done here) for all download/git clone/... stuffs.
Then only the part of relevant code (i.e. the use case related code) can be copied in the final image.
Please, note, it will require to remove the generic nox file at the /tools/nox path to copy/paste its content in the nox_file.py in each use-case, such that the divergence of each use-case will not break the nox sessions.

[A669015]

The docker image built in our internal repo are good example of the method.

[rdruilhe]

To avoid downloading the whole git repository, Lionel suggest to create a multistage Dockerfile with a first step including an image dedicated to download the files. Then, in the final image, a copy of the correct subfolders is made between the downloader and image. I agree with this way of doing stuffs.