Skip to content

Add PEtab SciML benchmarks - #3203

Merged
BSnelling merged 9 commits into
mainfrom
bes/petab_sciml_benchmarks
Jul 14, 2026
Merged

Add PEtab SciML benchmarks#3203
BSnelling merged 9 commits into
mainfrom
bes/petab_sciml_benchmarks

Conversation

@BSnelling

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.82%. Comparing base (266e23f) to head (c600bc4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
- Coverage   78.46%   77.82%   -0.64%     
==========================================
  Files         317      317              
  Lines       20968    20968              
  Branches     1483     1482       -1     
==========================================
- Hits        16452    16318     -134     
- Misses       4508     4642     +134     
  Partials        8        8              
Flag Coverage Δ
cpp 72.07% <100.00%> (-0.01%) ⬇️
cpp_python 36.66% <0.00%> (-0.01%) ⬇️
petab 47.15% <0.00%> (-0.02%) ⬇️
petab_sciml 16.22% <100.00%> (+<0.01%) ⬆️
petab_sciml_benchmarks 14.77% <100.00%> (?)
python 70.30% <100.00%> (-0.01%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sim/jax/petab.py 91.34% <100.00%> (+0.03%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FFroehlich FFroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FFroehlich

Copy link
Copy Markdown
Member

@claude review once

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new CI workflow and test coverage for running the PEtab SciML benchmark suite, and updates the JAX/PEtab SciML HDF5 array-loading logic to support the benchmark models.

Changes:

  • Added a new pytest module to execute PEtab SciML benchmarks and compare expected LLH values.
  • Updated HDF5 array loading in the JAX PEtab SciML integration to load parameters/inputs by configured neural-network IDs.
  • Added a dedicated GitHub Actions workflow to download the benchmark suite and run the new tests with coverage upload.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
tests/sciml_benchmarks/test_sciml_benchmarks.py New benchmark-driven pytest verifying JAX simulation LLH against expected YAML solutions.
python/sdist/amici/sim/jax/petab.py Adjusts loading of neural-network parameter/input arrays from SciML HDF5 files.
.github/workflows/test_petab_sciml_benchmarks.yml New CI workflow to fetch the benchmark suite, install dependencies, and run the benchmark tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread python/sdist/amici/sim/jax/petab.py
Comment thread python/sdist/amici/sim/jax/petab.py
Comment thread tests/sciml_benchmarks/test_sciml_benchmarks.py
Comment thread .github/workflows/test_petab_sciml_benchmarks.yml Outdated
Comment thread .github/workflows/test_petab_sciml_benchmarks.yml Outdated
Comment thread tests/sciml_benchmarks/test_sciml_benchmarks.py
BSnelling and others added 9 commits July 14, 2026 09:10
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@BSnelling
BSnelling force-pushed the bes/petab_sciml_benchmarks branch from ac2d226 to c600bc4 Compare July 14, 2026 08:10
@BSnelling
BSnelling marked this pull request as ready for review July 14, 2026 09:20
@BSnelling
BSnelling requested a review from a team as a code owner July 14, 2026 09:20

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@BSnelling
BSnelling added this pull request to the merge queue Jul 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 14, 2026
@BSnelling
BSnelling added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 62db707 Jul 14, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants