Skip to content

refactor: migrate to typescript#1625

Merged
faustbrian merged 274 commits intodevelopfrom
ts-config
Dec 13, 2018
Merged

refactor: migrate to typescript#1625
faustbrian merged 274 commits intodevelopfrom
ts-config

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

@faustbrian faustbrian commented Dec 4, 2018

Proposed changes

  • Resolves https://github.com/ArkEcosystem/core/milestone/3
  • Fixes a bug in core-container and resolveOptions that could result in null resolutions or providing options for plugins that are not even registered in the container
  • Fixed some return and value assignment issues where for example a BigNumber object was expected but a Number was assigned (JS didn't catch this and we had some tests that were passing even though they should have been failing)
  • Moved the peers.json config into the defaults of core-p2p as they are only used there and not by anything else (dc582fe). This means peers.json is now solely used to store the peer lists, more changes will follow in an upcoming PR.
  • Resolved various minor bugs that showed up during the migration
  • Added the yarn setup command to install, bootstrap and build all packages
  • Merged core-transaction-pool and core-transaction-pool-mem

Have been forging for some time with this branch on devnet now and had no errors occur so far.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost ghost assigned faustbrian Dec 4, 2018
@ghost ghost added the review label Dec 4, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@4a05143). Click here to learn what that means.
The diff coverage is 7.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1625   +/-   ##
==========================================
  Coverage           ?   39.41%           
==========================================
  Files              ?      353           
  Lines              ?     7675           
  Branches           ?     1099           
==========================================
  Hits               ?     3025           
  Misses             ?     4633           
  Partials           ?       17
Impacted Files Coverage Δ
packages/core-blockchain/src/queue/interface.ts 90% <ø> (ø)
...ockchain/src/machines/actions/sync-with-network.ts 100% <ø> (ø)
...ages/core-api/src/versions/2/wallets/controller.ts 0% <ø> (ø)
packages/core-api/src/versions/utils.ts 0% <ø> (ø)
packages/core-api/src/versions/2/votes/schema.ts 0% <ø> (ø)
...kages/core-blockchain/src/machines/actions/fork.ts 100% <ø> (ø)
...ges/core-api/src/versions/2/wallets/transformer.ts 0% <ø> (ø)
packages/core-api/src/versions/2/wallets/schema.ts 0% <ø> (ø)
packages/core-api/src/versions/2/wallets/routes.ts 0% <ø> (ø)
...chain/src/machines/actions/rebuild-from-network.ts 100% <ø> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a05143...38e820f. Read the comment docs.

@faustbrian faustbrian requested a review from spkjp December 4, 2018 08:02
@faustbrian faustbrian changed the title [WIP] refactor(core-config): migrate to typescript refactor(core-config): migrate to typescript Dec 4, 2018
@faustbrian faustbrian changed the title refactor(core-config): migrate to typescript [WIP] refactor(core-config): migrate to typescript Dec 4, 2018
@faustbrian faustbrian changed the title [WIP] refactor(core-config): migrate to typescript [WIP] refactor: migrate to typescript Dec 5, 2018
@faustbrian faustbrian merged commit fad5a25 into develop Dec 13, 2018
@ghost ghost removed the review label Dec 13, 2018
@faustbrian faustbrian deleted the ts-config branch December 13, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants