refactor: migrate to typescript#1625
Merged
faustbrian merged 274 commits intodevelopfrom Dec 13, 2018
Merged
Conversation
added 6 commits
December 5, 2018 05:29
kristjank
approved these changes
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
core-containerandresolveOptionsthat could result in null resolutions or providing options for plugins that are not even registered in the containerBigNumberobject was expected but aNumberwas assigned (JS didn't catch this and we had some tests that were passing even though they should have been failing)peers.jsonconfig into the defaults ofcore-p2pas they are only used there and not by anything else (dc582fe). This meanspeers.jsonis now solely used to store the peer lists, more changes will follow in an upcoming PR.yarn setupcommand to install, bootstrap and build all packagescore-transaction-poolandcore-transaction-pool-memHave been forging for some time with this branch on devnet now and had no errors occur so far.
Types of changes
Checklist