fix(core-json-rpc): return the encoded WIF for BIP38 wallets instead of the encrypted WIF#1653
Merged
faustbrian merged 4 commits intodevelopfrom Dec 6, 2018
Merged
fix(core-json-rpc): return the encoded WIF for BIP38 wallets instead of the encrypted WIF#1653faustbrian merged 4 commits intodevelopfrom
faustbrian merged 4 commits intodevelopfrom
Conversation
12 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1653 +/- ##
===========================================
+ Coverage 72.29% 74.98% +2.68%
===========================================
Files 483 444 -39
Lines 8778 7958 -820
Branches 1155 1047 -108
===========================================
- Hits 6346 5967 -379
+ Misses 2155 1768 -387
+ Partials 277 223 -54
Continue to review full report at Codecov.
|
spkjp
previously approved these changes
Dec 6, 2018
This should never happen unless, obviously, your node is not synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #1644 and also changes how BIP38 wallets are accessed.
Types of changes
Checklist