New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-json-rpc): return the encoded WIF for BIP38 wallets instead of the encrypted WIF #1653

Merged
merged 4 commits into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@faustbrian
Collaborator

faustbrian commented Dec 5, 2018

Proposed changes

Resolves #1644 and also changes how BIP38 wallets are accessed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • [x Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from supaiku0 Dec 5, 2018

@wafflebot wafflebot bot added the review label Dec 5, 2018

@faustbrian faustbrian changed the title from fix(core-json-rpc): properly handle bip38 creation and reading for wallets to fix(core-json-rpc): properly handle bip38 creation and reading for wallets Dec 5, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 5, 2018

Codecov Report

Merging #1653 into develop will increase coverage by 2.68%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1653      +/-   ##
===========================================
+ Coverage    72.29%   74.98%   +2.68%     
===========================================
  Files          483      444      -39     
  Lines         8778     7958     -820     
  Branches      1155     1047     -108     
===========================================
- Hits          6346     5967     -379     
+ Misses        2155     1768     -387     
+ Partials       277      223      -54
Impacted Files Coverage Δ
...ages/core-json-rpc/lib/server/utils/decrypt-wif.js 100% <100%> (ø)
...son-rpc/lib/server/methods/wallets/bip38/create.js 93.75% <100%> (+0.89%) ⬆️
.../core-json-rpc/lib/server/methods/blocks/latest.js 100% <100%> (ø) ⬆️
...kages/core-json-rpc/lib/server/utils/bip38-keys.js 90.9% <100%> (-1.4%) ⬇️
...-json-rpc/lib/server/methods/wallets/bip38/show.js 100% <100%> (ø) ⬆️
packages/core-container/lib/index.js
packages/core-tester-cli/lib/utils/logger.js
packages/core-transaction-pool-mem/lib/index.js
packages/core-tester-cli/lib/config/index.js
...s/core-tester-cli/lib/commands/second-signature.js
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aff430...adc554f. Read the comment docs.

@faustbrian faustbrian changed the title from fix(core-json-rpc): properly handle bip38 creation and reading for wallets to fix(core-json-rpc): return the encoded WIF for BIP38 wallets instead of the encrypted WIF Dec 5, 2018

fix(core-json-rpc): return 404 if the last block is not found
This should never happen unless, obviously, your node is not synced.

@faustbrian faustbrian merged commit 3a0b19b into develop Dec 6, 2018

3 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the rpcbip branch Dec 6, 2018

@wafflebot wafflebot bot removed the review label Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment