Skip to content

feat(core-api): return the transaction expiration time via node/configuration#1927

Merged
faustbrian merged 2 commits intodevelopfrom
feat/api-tx-age
Jan 3, 2019
Merged

feat(core-api): return the transaction expiration time via node/configuration#1927
faustbrian merged 2 commits intodevelopfrom
feat/api-tx-age

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

Proposed changes

Resolves #1899

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost ghost assigned faustbrian Jan 3, 2019
@ghost ghost added the review label Jan 3, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 3, 2019

Codecov Report

Merging #1927 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1927      +/-   ##
===========================================
- Coverage    39.55%   39.55%   -0.01%     
===========================================
  Files          350      350              
  Lines         7622     7623       +1     
  Branches      1156     1133      -23     
===========================================
  Hits          3015     3015              
- Misses        4593     4595       +2     
+ Partials        14       13       -1
Impacted Files Coverage Δ
...ackages/core-api/src/versions/2/node/controller.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bb3b6...eff3bef. Read the comment docs.

@faustbrian faustbrian merged commit 18120a3 into develop Jan 3, 2019
@faustbrian faustbrian deleted the feat/api-tx-age branch January 3, 2019 06:21
@ghost ghost removed the review label Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants